linux-kernel - Re: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150714224138.GG20482@piout.net>
Date:	Wed, 15 Jul 2015 00:41:38 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Maninder Singh <maninder1.s@...sung.com>
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, pankaj.m@...sung.com
Subject: Re: [PATCH 1/1] drivers/rtc/rtc-bq32k.c: remove redundant check

Hi,

On 08/07/2015 at 12:26:47 +0530, Maninder Singh wrote :
> removing below static analysis error:-

What tool did you use?

> (error) Possible null pointer dereference: client
> 
> if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
> 							^^^^^^^
> Error comes beacause client is dereferenced before NULL check.
> So probabily NULL this check is not required.
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> ---
>  drivers/rtc/rtc-bq32k.c |    2 +-
Applied, to rtc-next.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/