linux-kernel - Re: config PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <559D3134.1080603@endocode.com>
Date:	Wed, 8 Jul 2015 16:18:28 +0200
From:	Iago López Galeiras <iago@...ocode.com>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Djalal Harouni <djalal@...ocode.com>,
	Alban Crequy <alban@...ocode.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: config PROC_CHILDREN

On 07/04/2015 07:07 PM, Jean Delvare wrote:
> Hi Iago,
> 
> Please don't top-post.
> 
> On Fri, 3 Jul 2015 11:10:45 +0200, Iago López Galeiras wrote:
>> Hi Jean,
>>
>> The purpose of this option is enabling /proc/<pid>/task/<tid>/children without
>> having to enable CHECKPOINT_RESTORE, which is hidden behind EXPERT.
>>
>> Regarding its lack of help, documentation is in already in place[1] but perhaps
>> that's not clear for the user because as you say the Kconfig help text is missing.
>>
>> I suggest adding something like:
>>
>>     Provides a fast way to retrieve first level children pids of a task. See
>>     <file:Documentation/filesystems/proc.txt> for more information.
>>
>> Do you think that's enough?
> 
> That's a start, the reference to Documentation/filesystems/proc.txt is
> good but I think we can do better. You need to help the user make the
> decision. Why should he/she say Y or N? The user should NOT have to look
> at an external documentation file if the answer is N. I would suggest
> the following:
> 
> Say Y if running any user-space software which takes benefit from this
> interface. For example, rkt is such a piece of software.

That makes it more clear for the user. Thanks!

> That being said, I am curious... Is this interface so expensive that it
> really deserves a separate option, instead of always enabling it? This
> seems to be a fairly generic feature that a lot of scripts and tools
> could benefit from (starting with pstree I suppose.)

I don't think I have enough information to answer that question. I'll CC Cyrill
Gorcunov and Andrew Morton.

-- 

Iago López Galeiras
Software developer @ Endocode AG
iago@...ocode.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/