lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2686ba70b03b3e16c94f93052aa56703.squirrel@www.codeaurora.org>
Date:	Wed, 8 Jul 2015 11:56:33 -0600
From:	"Ankit Gupta" <ankgupta@...eaurora.org>
To:	"Thomas Gleixner" <tglx@...utronix.de>
Cc:	"Steven Rostedt" <rostedt@...dmis.org>,
	"Ankit Gupta" <ankgupta@...eaurora.org>, mingo@...hat.com,
	agross@...eaurora.org, davem@...emloft.net, rdunlap@...radead.org,
	standby24x7@...il.com, sboyd@...eaurora.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	gavidov@...eaurora.org, sdharia@...eaurora.org,
	linux-arm-msm@...r.kernel.org, mlocke@...eaurora.org
Subject: Re: [PATCH V3] trace/events: add chip name and hwirq to irq entry
 tracepoint

> On Wed, 24 Jun 2015, Steven Rostedt wrote:
>> > +
>> > +#define show_chip_name(irq)					\
>> > +	(irq_get_irq_data(irq)					\
>> > +			 ? irq_get_irq_data(irq)->chip->name	\
>> > +			 : "NULL")
>> > +
>> > +#define show_hwirq(irq)						\
>> > +	(irq_get_irq_data(irq)					\
>> > +			 ? irq_get_irq_data(irq)->hwirq		\
>> > +			 : -ENODEV)
>>
>> Note these magic functions will only be useful for the tracefs reads of
>> the trace files. Userspace tools that extract the data (like perf and
>> trace-cmd), will have no idea of how to parse it.
>>
>> I'm not against doing this, but I'm just letting you know what the
>> effect of this change will be.
>
> What's worse is, that they are racy against a concurrent teardown of
> the interrupt. Not a good idea ...
>

Agree, I'll save the chip-name and hwirq in the struct. This technique
using the same macros to save the chip-name and hwirq in the struct also
works well with trace-cmd.

Thanks,
Ankit and Gilad

> Thanks,
>
> 	tglx
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm"
> in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ