linux-kernel - Re: [PATCH] cdc-acm: Destroy acm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709085706.GB18161@localhost>
Date:	Thu, 9 Jul 2015 10:57:06 +0200
From:	Johan Hovold <johan@...nel.org>
To:	Johannes Thumshirn <jthumshirn@...e.de>
Cc:	Oliver Neukum <oliver@...kum.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdc-acm: Destroy acm_minors IDR on module exit

On Wed, Jul 08, 2015 at 05:25:42PM +0200, Johannes Thumshirn wrote:
> Destroy acm_minors IDR on module exit, reclaiming the allocated memory.

> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
>  drivers/usb/class/cdc-acm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
> index 519a77b..b30e742 100644
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -1944,6 +1944,7 @@ static void __exit acm_exit(void)
>  	usb_deregister(&acm_driver);
>  	tty_unregister_driver(acm_tty_driver);
>  	put_tty_driver(acm_tty_driver);
> +	idr_destroy(&acm_minors);
>  }
>  
>  module_init(acm_init);

Acked-by: Johan Hovold <johan@...nel.org>

No stable-tag needed as idr wasn't used before 4.2.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/