linux-kernel - Re: [PATCH 1/2] ASoC: rt5645: Fix missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150709111010.GL11162@sirena.org.uk>
Date:	Thu, 9 Jul 2015 12:10:10 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Koro Chen <koro.chen@...iatek.com>
Cc:	perex@...ex.cz, tiwai@...e.de, lgirdwood@...il.com,
	srv_heupstream@...iatek.com, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, bardliao@...ltek.com,
	oder_chiou@...ltek.com
Subject: Re: [PATCH 1/2] ASoC: rt5645: Fix missing free_irq

On Thu, Jul 09, 2015 at 09:48:13AM +0800, Koro Chen wrote:

> Do you think I should use devm_request_threaded_irq(), and change
> free_irq to devm_free_irq in remove? Or I should keep the original
> request_thread_irq(), and just add a free_irq() during probe failed?

I'd just keep request_threaded_irq() and use free_irq().

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)