linux-kernel - Re: [PATCH 1/2] ASoC: rt5645: Fix missing free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436539401.6170.2.camel@mtksdaap41>
Date:	Fri, 10 Jul 2015 22:43:21 +0800
From:	Koro Chen <koro.chen@...iatek.com>
To:	Mark Brown <broonie@...nel.org>
CC:	<perex@...ex.cz>, <tiwai@...e.de>, <lgirdwood@...il.com>,
	<srv_heupstream@...iatek.com>, <linux-kernel@...r.kernel.org>,
	<alsa-devel@...a-project.org>, <bardliao@...ltek.com>,
	<oder_chiou@...ltek.com>
Subject: Re: [PATCH 1/2] ASoC: rt5645: Fix missing free_irq

On Thu, 2015-07-09 at 12:10 +0100, Mark Brown wrote:
> On Thu, Jul 09, 2015 at 09:48:13AM +0800, Koro Chen wrote:
> 
> > Do you think I should use devm_request_threaded_irq(), and change
> > free_irq to devm_free_irq in remove? Or I should keep the original
> > request_thread_irq(), and just add a free_irq() during probe failed?
> 
> I'd just keep request_threaded_irq() and use free_irq().
OK, thanks, I will send a new patch.
And about the patch 2/2 regulator support, is there any problem I should
also fix?
 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/