linux-kernel - Re: [PATCH] regulators: Add missing dummy definition for regulator_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <559FE151.2030305@arm.com>
Date:	Fri, 10 Jul 2015 16:14:25 +0100
From:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
To:	Mark Brown <broonie@...nel.org>
CC:	"sfr@...b.auug.org.au" <sfr@...b.auug.org.au>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"paul@...an.com" <paul@...an.com>,
	"treding@...dia.com" <treding@...dia.com>,
	Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH] regulators: Add missing dummy definition for regulator_list_voltage

On 07/07/15 13:38, Mark Brown wrote:
> On Fri, Jun 26, 2015 at 12:06:50PM +0100, Suzuki K. Poulose wrote:
>
>> +static inline int regulator_list_voltage(struct regulator *regulator, unsigned selector)
>> +{
>> +	return 0;
>> +}
>
> I'd expect this stub to return -EINVAL since the voltage count should be
> zero for !REGULATOR (since we obviously can't count the number of
> voltages).
>
You are right, -EINVAL suites better. There are some users of the
API who consider 0 as invalid, but -EINVAL sounds better and covers
all the existing uses. Will resend the patch.

Thanks
Suzuki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/