linux-kernel - Re: [RFC] kthread_create_on_node is failing to honor the node choice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150710173445.GA39511@asylum.americas.sgi.com>
Date:	Fri, 10 Jul 2015 12:34:45 -0500
From:	Nathan Zimmer <nzimmer@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Nathan Zimmer <nzimmer@....com>,
	Nishanth Aravamudan <nacc@...ux.vnet.ibm.com>,
	Tejun Heo <tj@...nel.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, linux-kernel@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [RFC] kthread_create_on_node is failing to honor the node
	choice


On Thu, Jul 09, 2015 at 03:12:59PM -0700, Andrew Morton wrote:
> On Thu, 25 Jun 2015 16:44:13 -0500 Nathan Zimmer <nzimmer@....com> wrote:
> 
> > In kthread_create_on_node we set_cpus_allowed to cpu_all_mask
> > regardless of what the node is requested.
> > This seems incorrect.
> 
> The `node' arg to kthread_create_on_node() refers to which node the
> task_struct and thread_info are allocated from.  It doesn't refer to
> the CPUs upon which the thread is executed.  See
> kthread_create_info.node and that gruesome task_struct.pref_node_fork
> thing.
> 
> The kthread_create_on_node() kerneldoc explains this, in a confused
> way.  It needs a s/-1/NUMA_NO_NODE/.


I suspect we should also update the kthread_create macro to use NUMA_NO_NODE also.


diff --git a/include/linux/kthread.h b/include/linux/kthread.h
index 13d5520..3e6773e 100644
--- a/include/linux/kthread.h
+++ b/include/linux/kthread.h
@@ -11,7 +11,7 @@ struct task_struct *kthread_create_on_node(int (*threadfn)(void *data),
 					   const char namefmt[], ...);
 
 #define kthread_create(threadfn, data, namefmt, arg...) \
-	kthread_create_on_node(threadfn, data, -1, namefmt, ##arg)
+	kthread_create_on_node(threadfn, data, NUMA_NO_NODE, namefmt, ##arg)
 
 
 struct task_struct *kthread_create_on_cpu(int (*threadfn)(void *data),
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/