linux-kernel - Re: [PATCH] firmware: Fix dereferencing NULL pointer of fw_priv->buf->fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150712170117.4017400f@grimm.local.home>
Date:	Sun, 12 Jul 2015 17:01:17 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	David Howells <dhowells@...hat.com>,
	Ming Lei <ming.lei@...onical.com>,
	Seth Forshee <seth.forshee@...onical.com>,
	Kyle McMartin <kyle@...nel.org>,
	"Luis R. Rodriguez" <mcgrof@...e.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] firmware: Fix dereferencing NULL pointer of
 fw_priv->buf->fw_id

On Sun, 12 Jul 2015 13:50:19 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Sun, Jul 12, 2015 at 11:49 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > Unfortunately, this caused the following BUG:
> 
> I'm hoping you didn't waste too much time on this.

Well, not that much. I was able to automate the bisects. But it did
cause me to waste time in my own testing, which needs to be restarted
because this bug caused my tests to fail.

> 
> Because check commit 6f957724b94c, which fixes the NULL pointer
> dereference _and_ the lack of proper locking.
> 

Thanks, I'll take note.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/