linux-kernel - Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1436949405.2679.67.camel@tiscali.nl>
Date:	Wed, 15 Jul 2015 10:36:45 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Peter Hung <hpeter@...il.com>
Cc:	johan@...nel.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	tom_tsai@...tek.com.tw, peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

Just a few nits, I'm afraid.

On di, 2015-07-14 at 11:13 +0800, Peter Hung wrote:
> --- /dev/null
> +++ b/drivers/usb/serial/f81534.c

> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
> +{
> +	[...]
> +}

static?

> +void f81534_gpio_free(struct gpio_chip *chip, unsigned offset)
> +{
> +	[...]
> +}

Ditto.

> +static struct gpio_chip f81534_gpio_chip_templete = {
> +	[...]
> +	.request = f81534_gpio_request,
> +	.free = f81534_gpio_free,
> +	[...]
> +};

> +int f81534_ioctl_set_rs485(struct usb_serial_port *port,
> +			   struct serial_rs485 __user *arg)
> +{
> +	[...]
> +}

Ditto.

> +static int f81534_ioctl(struct tty_struct *tty, unsigned int cmd,
> +			unsigned long arg)
> +{
> +	[...]
> +	case TIOCSRS485:
> +		return f81534_ioctl_set_rs485(port,
> +					      (struct serial_rs485 __user *)
> +					      arg);
> +	[...]
> +}

> +int f81534_prepare_write_buffer(struct usb_serial_port *port,
> +						void *dest, size_t size)
> +{
> +	[...]
> +}

Ditto.

> +static struct usb_serial_driver f81534_device = {
> +	[...]
> +	.prepare_write_buffer = f81534_prepare_write_buffer,
> +	.[...]
> +};
> +
> +static struct usb_serial_driver *const serial_drivers[] = {
> +	&f81534_device, NULL
> +};
> +

If you drop this empty line ...

> +module_usb_serial_driver(serial_drivers, id_table);

and add an empty line here, things look neater.

> +MODULE_DESCRIPTION(DRIVER_DESC);
> +MODULE_AUTHOR("Peter Hong <Peter_Hong@...tek.com.tw>");
> +MODULE_AUTHOR("Tom Tsai <Tom_Tsai@...tek.com.tw>");
> +MODULE_LICENSE("GPL");

Thanks,


Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/