linux-kernel - Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A61FF7.5030804@gmail.com>
Date:	Wed, 15 Jul 2015 16:55:19 +0800
From:	Peter Hung <hpeter@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>, johan@...nel.org
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org, tom_tsai@...tek.com.tw,
	peter_hong@...tek.com.tw,
	Peter Hung <hpeter+linux_kernel@...il.com>
Subject: Re: [PATCH V4 1/1] usb:serial:f81534 add F81532/534 driver

Hi Paul & Johan

Paul Bolle 於 2015/7/15 下午 04:36 寫道:
> Just a few nits, I'm afraid.
>> +int f81534_gpio_request(struct gpio_chip *chip, unsigned offset)
>> +{
>> +	[...]
>> +}
>
> static?

Thanks Paul for point this out.

And sorry for Johan. It's seems to make a new patch V5. I'll merge
some minor fix with newer patch.
-- 
With Best Regards,
Peter Hung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/