linux-kernel - Re: [patch 1/3] avr32/at32ap: Consolidate chained IRQ handler install/remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715115157.GA32762@samfundet.no>
Date:	Wed, 15 Jul 2015 13:51:57 +0200
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Julia Lawall <Julia.Lawall@...6.fr>
Subject: Re: [patch 1/3] avr32/at32ap: Consolidate chained IRQ handler
 install/remove

Around Mon 13 Jul 2015 20:31:09 -0000 or thereabout, Thomas Gleixner wrote:
> Chained irq handlers usually set up handler data as well. We now have
> a function to set both under irq_desc->lock. Replace the two calls
> with one.
> 
> Search and conversion was done with coccinelle.
> 
> Reported-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Julia Lawall <Julia.Lawall@...6.fr>
> Cc: Haavard Skinnemoen <hskinnemoen@...il.com>
> Cc: Hans-Christian Egtvedt <egtvedt@...fundet.no>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

> ---
>  arch/avr32/mach-at32ap/pio.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: tip/arch/avr32/mach-at32ap/pio.c
> ===================================================================
> --- tip.orig/arch/avr32/mach-at32ap/pio.c
> +++ tip/arch/avr32/mach-at32ap/pio.c
> @@ -312,7 +312,6 @@ gpio_irq_setup(struct pio_device *pio, i
>  	unsigned	i;
>  
>  	irq_set_chip_data(irq, pio);
> -	irq_set_handler_data(irq, (void *)gpio_irq);
>  
>  	for (i = 0; i < 32; i++, gpio_irq++) {
>  		irq_set_chip_data(gpio_irq, pio);
> @@ -320,7 +319,8 @@ gpio_irq_setup(struct pio_device *pio, i
>  					 handle_simple_irq);
>  	}
>  
> -	irq_set_chained_handler(irq, gpio_irq_handler);
> +	irq_set_chained_handler_and_data(irq, gpio_irq_handler,
> +					 (void *)gpio_irq);
>  }
>  
>  /*--------------------------------------------------------------------------*/
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/