linux-kernel - Re: [patch 2/3] avr32/at32ap: Use irq_set_handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Jul 2015 13:52:09 +0200
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Haavard Skinnemoen <hskinnemoen@...il.com>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [patch 2/3] avr32/at32ap: Use irq_set_handler_locked()

Around Mon 13 Jul 2015 20:31:10 -0000 or thereabout, Thomas Gleixner wrote:
> Use irq_set_handler_locked() as it avoids a redundant lookup of the
> irq descriptor.
> 
> Search and replacement was done with coccinelle.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Jiang Liu <jiang.liu@...ux.intel.com>
> Cc: Julia Lawall <julia.lawall@...6.fr>
> Cc: Haavard Skinnemoen <hskinnemoen@...il.com>
> Cc: Hans-Christian Egtvedt <egtvedt@...fundet.no>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

> ---
>  arch/avr32/mach-at32ap/extint.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Index: tip/arch/avr32/mach-at32ap/extint.c
> ===================================================================
> --- tip.orig/arch/avr32/mach-at32ap/extint.c
> +++ tip/arch/avr32/mach-at32ap/extint.c
> @@ -128,9 +128,9 @@ static int eic_set_irq_type(struct irq_d
>  
>  	irqd_set_trigger_type(d, flow_type);
>  	if (flow_type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_LEVEL_HIGH))
> -		__irq_set_handler_locked(irq, handle_level_irq);
> +		irq_set_handler_locked(d, handle_level_irq);
>  	else
> -		__irq_set_handler_locked(irq, handle_edge_irq);
> +		irq_set_handler_locked(d, handle_edge_irq);
>  
>  	return IRQ_SET_MASK_OK_NOCOPY;
>  }
-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/