linux-kernel - Re: [PATCH] regulator: core: Fix memory leak in regulator_resolve

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150715155254.GR11162@sirena.org.uk>
Date:	Wed, 15 Jul 2015 16:52:54 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier@....samsung.com>
Cc:	Krzysztof Kozlowski <k.kozlowski@...sung.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: core: Fix memory leak in
 regulator_resolve_supply()

On Wed, Jul 15, 2015 at 02:46:25PM +0200, Javier Martinez Canillas wrote:
> On 07/15/2015 01:27 PM, Mark Brown wrote:

> > using _regulator_get() I think.  A separate, rarely used, path is likely
> > to have this sort of issue.

> Exactly, do you agree then that a try_module_get() is missing in set_supply()?

> It is OK if I add that in the same patch in v2 or do you prefer that to be
> in a separate patch?

A separate patch would be better, or even better would be something that
just replaces everything there with use of the same code path as _get()
(thanks for volunteering!) but just adding the try_module_get() is fine
for now.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)