linux-kernel - Re: [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <55A682F8.3090001@ni.com>
Date:	Wed, 15 Jul 2015 10:57:44 -0500
From:	Xander Huff <xander.huff@...com>
To:	Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>
CC:	jic23@...nel.org, bigeasy@...utronix.de, lars@...afoo.de,
	nathan.sullivan@...com, linux-rt-users@...r.kernel.org,
	linux-iio@...r.kernel.org, jaeden.amero@...com, joshc@...com,
	michal.simek@...inx.com, linux-kernel@...r.kernel.org,
	joe.hershberger@...com, linux-arm-kernel@...ts.infradead.org,
	pmeerw@...erw.net, knaack.h@....de, soren.brinkmann@...inx.com
Subject: Re: [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded
 context

On 7/9/2015 12:03 AM, Shubhrajyoti Datta wrote:
>     @@ -330,8 +310,18 @@ static irqreturn_t xadc_zynq_interrupt_handler(int irq,
>     void *devid)
>                      xadc_zynq_update_intmsk(xadc, 0, 0);
>                      ret = IRQ_WAKE_THREAD;
>              }
>     +
>     +       alarm = xadc->zynq_alarm;
>     +       xadc->zynq_alarm = 0;
>     +
>              spin_unlock(&xadc->lock);
>
>     +       xadc_handle_events(indio_dev, xadc_zynq_transform_alarm(alarm));
>     +
>     +       /* unmask the required interrupts in timer. */
>     +       schedule_delayed_work(&xadc->zynq_unmask_work,
>     +                       msecs_to_jiffies(XADC_ZYNQ_UNMASK_TIMEOUT));
>     +
>
> Now that we are in the threaded context do we need the  work queue stuff.
Seems reasonable to try to remove it. I'll do some testing and send out a v3 if 
it works, thanks.

-- 
Xander Huff
Staff Software Engineer
National Instruments
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/