linux-kernel - Re: [PATCH v5] i8042: Add unmask_kbd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1436980570.10553.0.camel@redhat.com>
Date:	Wed, 15 Jul 2015 13:16:10 -0400
From:	Stephen Chandler Paul <cpaul@...hat.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Hans de Goede <hdegoede@...hat.com>,
	Andreas Mohr <andi@...as.de>
Subject: Re: [PATCH v5] i8042: Add unmask_kbd_data option

On Wed, 2015-07-15 at 09:59 -0700, Dmitry Torokhov wrote:
> Hi Stephen,
> 
> On Thu, Jul 02, 2015 at 11:46:48AM -0400, cpaul@...hat.com wrote:
> > +static int i8042_kbd_bind_notifier(struct notifier_block *nb,
> > +				   unsigned long action, void 
> > *data)
> > +{
> > +	struct device *dev = data;
> > +	struct serio *serio = to_serio_port(dev);
> > +	struct i8042_port *port = serio->port_data;
> > +
> > +	if (serio != i8042_ports[I8042_KBD_PORT_NO].serio)
> > +		return 0;
> > +
> > +	switch (action) {
> > +	case BUS_NOTIFY_BOUND_DRIVER:
> > +		port->driver_bound = true;
> > +		break;
> > +
> > +	case BUS_NOTIFY_UNBOUND_DRIVER:
> 
> I think it should be BUS_NOTIFY_UNBIND_DRIVER so that we see the KBD
> data as it goes through driver cleanup. Yell if you disagree, or I'll
> change it locally.
Sounds good to me

Cheers,
	Stephen Chandler Paul

> 
> Thanks.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/