lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1437069139.2495.12.camel@perches.com>
Date:	Thu, 16 Jul 2015 10:52:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Craig Inches <craig.inches@...itas.com>
Cc:	Craig Inches <craig.inches@...to.net>, lidza.louina@...il.com,
	markh@...pro.net, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: drivers: dgnc

On Fri, 2015-07-17 at 00:20 +0000, Craig Inches wrote:
> Hi Joe,

Rehi Craig.

> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line greater than 80 Chars in multiple locations.
> > 
> > I think most all of these are not improvements.
> 	Ok, can you be a little more specific? I did see some that where
> 	not worth modifying due to only being 1 or 2 chars over, and
> 	breaking the line seemed pointless.

Precisely.

Please don't do things you recognize as pointless
just to satisfy some brainless script.

> > Please use --strict when verifying your patches.
> 	Not sure where the --strict should be set? I cant see the option
> 	in  the checklist.pl script 

$ ./scripts/checkpatch.pl --help
[...]
  --subjective, --strict     enable more subjective tests
[...]
$


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ