linux-kernel - Re: [PATCH] Staging: drivers: dgnc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717005719.GA17691@Morat.xayto.local>
Date:	Fri, 17 Jul 2015 00:57:19 +0000
From:	Craig Inches <Craig.Inches@...to.net>
To:	Craig Inches <craig.inches@...itas.com>
Cc:	Joe Perches <joe@...ches.com>,
	Craig Inches <craig.inches@...to.net>, lidza.louina@...il.com,
	markh@...pro.net, gregkh@...uxfoundation.org,
	driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: drivers: dgnc

On Fri, Jul 17, 2015 at 12:20:42AM +0000, Craig Inches wrote:
> Hi Joe,
> 
> On Thu, Jul 16, 2015 at 08:30:53AM -0700, Joe Perches wrote:
> > On Thu, 2015-07-16 at 23:11 +0000, Craig Inches wrote:
> > > Fixed up some checkpatch.pl style issues.
> > > Line greater than 80 Chars in multiple locations.
> > 
> > I think most all of these are not improvements.
> 	Ok, can you be a little more specific? I did see some that where
> 	not worth modifying due to only being 1 or 2 chars over, and
> 	breaking the line seemed pointless.
> 
> > Please use --strict when verifying your patches.
> 	Not sure where the --strict should be set? I cant see the option
> 	in  the checklist.pl script 
	found it missed the line after --subjective with -h  
	I shall take another crack at a patch, I see some issues
	introduced which wern't reported with just a normal
	checkpatch.pl run.

> > Please fix the time on your systemp.
> 	Thanks for pointing that out, my mail servers time was out.
> 
> Thanks for your feedback.
> Craig

-- 
Craig Inches

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/