linux-kernel - Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2015 11:08:28 +0100
From:	Malcolm Priestley <tvboxspy@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	Maninder Singh <maninder1.s@...sung.com>
CC:	"forest@...ttletooquiet.net" <forest@...ttletooquiet.net>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"gclement@...bob.org" <gclement@...bob.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>,
	PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [RESEND PATCH 1/1] staging:vt6655: remove checks around dev_kfree_skb



On 16/07/15 09:54, Dan Carpenter wrote:
> On Thu, Jul 16, 2015 at 08:45:06AM +0000, Maninder Singh wrote:
>> where we are checking for (pTDInfo->skb), we are using it  in above line.
>> and it does not look good, thats why we should remove thse checks and i have suggested
>> changes.
>>
>> code snippet:-
>> -----------------------
>>
>> if (pTDInfo->skb_dma && (pTDInfo->skb_dma != pTDInfo->buf_dma))
>        ^^^^^^^^^^^^^^^^
> This is allocated after ->skb so if ->skb_dma is non-NULL then ->skb is
> also non-NULL.
>
>>      dma_unmap_single(&pDevice->pcid->dev, pTDInfo->skb_dma,
>>               pTDInfo->skb->len, DMA_TO_DEVICE);
>
> Is this a static checker warning?  If so then it's a false positive.
>

This is old code dma_unmap_single never happens and is to be removed.

pTDInfo->skb now originates from mac80211.

I am in the process of tiding up pTDInfo that removes skb_dma.

In the past, this driver several API's sharing the same device now it 
has just one.

Regards


Malcolm

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/