linux-kernel - Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55A7A380.4000407@iogearbox.net>
Date:	Thu, 16 Jul 2015 14:28:48 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Denys Vlasenko <dvlasenk@...hat.com>
CC:	Thomas Graf <tgraf@...g.ch>,
	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords

On 07/16/2015 02:15 PM, Denys Vlasenko wrote:
> On 07/16/2015 12:41 PM, Thomas Graf wrote:
>> On 07/16/15 at 12:02pm, Denys Vlasenko wrote:
>>> +/* jhash - hash an arbitrary key
>>> + * @k: sequence of bytes as key
>>> + * @length: the length of the key
>>> + * @initval: the previous hash, or an arbitray value
>>> + *
>>> + * The generic version, hashes an arbitrary sequence of bytes.
>>> + * No alignment or length assumptions are made about the input key.
>>> + *
>>> + * Returns the hash value of the key. The result depends on endianness.
>>> + */
>>> +u32 jhash(const void *key, u32 length, u32 initval)
>>
>> Shouldn't these live in lib/jhash.c or something? Otherwise
>> everyone needs to depend on CONFIG_RHASHTABLE
>
> There is no CONFIG_RHASHTABLE, rhashtable.c is compiled unconditionally.
>
> I will send an alternative patch, which creates jhash.c;
> apply whichever version you like most.

Please also Cc netdev as networking subsys is one of the main users
of jhash in various critical paths. Did you run e.g. some *_RR work
load benchmarks as well to make sure there's no regression?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/