linux-kernel - Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150716140451.GB22603@pox.localdomain>
Date:	Thu, 16 Jul 2015 16:04:51 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Denys Vlasenko <dvlasenk@...hat.com>
Cc:	Alexander Duyck <alexander.h.duyck@...hat.com>,
	Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jhash: Deinline jhash, jhash2 and __jhash_nwords

On 07/16/15 at 02:15pm, Denys Vlasenko wrote:
> On 07/16/2015 12:41 PM, Thomas Graf wrote:
> > On 07/16/15 at 12:02pm, Denys Vlasenko wrote:
> >> +/* jhash - hash an arbitrary key
> >> + * @k: sequence of bytes as key
> >> + * @length: the length of the key
> >> + * @initval: the previous hash, or an arbitray value
> >> + *
> >> + * The generic version, hashes an arbitrary sequence of bytes.
> >> + * No alignment or length assumptions are made about the input key.
> >> + *
> >> + * Returns the hash value of the key. The result depends on endianness.
> >> + */
> >> +u32 jhash(const void *key, u32 length, u32 initval)
> > 
> > Shouldn't these live in lib/jhash.c or something? Otherwise
> > everyone needs to depend on CONFIG_RHASHTABLE
> 
> There is no CONFIG_RHASHTABLE, rhashtable.c is compiled unconditionally.
> 
> I will send an alternative patch, which creates jhash.c;
> apply whichever version you like most.

Right. I misread the CONFIG_TEST_RHASHTABLE. I'm fine with this then
but agree with Daniel that this must be severely tested for
performance regressions.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/