linux-kernel - Re: [mminit] [ INFO: possible recursive locking detected ]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALYGNiMMeyW7GXHpdAONn4CckE5Q4cn64wwekZfk18q_W7xMsQ@mail.gmail.com>
Date:	Fri, 17 Jul 2015 08:06:49 +0300
From:	Konstantin Khlebnikov <koct9i@...il.com>
To:	Mel Gorman <mgorman@...e.de>
Cc:	Fengguang Wu <fengguang.wu@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Nicolai Stange <nicstange@...il.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	LKP <lkp@...org>
Subject: Re: [mminit] [ INFO: possible recursive locking detected ]

On Thu, Jul 16, 2015 at 8:51 PM, Mel Gorman <mgorman@...e.de> wrote:
> On Thu, Jul 16, 2015 at 08:13:38PM +0300, Konstantin Khlebnikov wrote:
>> > @@ -1187,14 +1195,14 @@ void __init page_alloc_init_late(void)
>> >  {pgdat_init_rwsempgdat_init_rwsempgdat_init_rwsem
>> >         int nid;
>> >
>> > +       /* There will be num_node_state(N_MEMORY) threads */
>> > +       atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));
>> >         for_each_node_state(nid, N_MEMORY) {
>> > -               down_read(&pgdat_init_rwsem);
>>
>> Rw-sem have special "non-owner" mode for keeping lockdep away.
>> This should be enough:
>>
>
> I think in this case that the completions look nicer though so I think
> I'll keep them.

Ok. Not a big deal, they are anyway in init sections.

BTW there's another option: wait_on_atomic_t / wake_up_atomic_t
like wait_on_bit but atomic_t

>
> --
> Mel Gorman
> SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/