lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 17 Jul 2015 14:11:19 +0900
From:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Applied "regulator: 88pm800: Remove owner" to the regulator tree

2015-07-17 6:19 GMT+09:00 Mark Brown <broonie@...nel.org>:
> The patch
>
>    regulator: 88pm800: Remove owner
>
> has been applied to the regulator tree at
>
>    git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
> From f44ca44b14d697a047b7c1b32b29a1d9881f050f Mon Sep 17 00:00:00 2001
> From: Mark Brown <broonie@...nel.org>
> Date: Thu, 16 Jul 2015 22:17:32 +0100
> Subject: [PATCH] regulator: 88pm800: Remove owner

Hi Mark,

I wonder why? Isn't the owner needed for module_get/module_put or am I
missing something?

Best regards,
Krzysztof

>
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>  drivers/regulator/88pm800.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/regulator/88pm800.c b/drivers/regulator/88pm800.c
> index e846e4c..1b3b3a1 100644
> --- a/drivers/regulator/88pm800.c
> +++ b/drivers/regulator/88pm800.c
> @@ -103,7 +103,6 @@ struct pm800_regulators {
>                 .ops                    = &pm800_volt_range_ops,        \
>                 .type                   = REGULATOR_VOLTAGE,            \
>                 .id                     = PM800_ID_##vreg,              \
> -               .owner                  = THIS_MODULE,                  \
>                 .n_voltages             = n_volt,                       \
>                 .linear_ranges          = volt_ranges,                  \
>                 .n_linear_ranges        = ARRAY_SIZE(volt_ranges),      \
> @@ -133,7 +132,6 @@ struct pm800_regulators {
>                 .ops                    = &pm800_volt_table_ops,        \
>                 .type                   = REGULATOR_VOLTAGE,            \
>                 .id                     = PM800_ID_##vreg,              \
> -               .owner                  = THIS_MODULE,                  \
>                 .n_voltages             = ARRAY_SIZE(ldo_volt_table),   \
>                 .vsel_reg               = PM800_##vreg##_VOUT,          \
>                 .vsel_mask              = 0x1f,                         \
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ