linux-kernel - Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <55A8ABD8.7000705@samsung.com>
Date:	Fri, 17 Jul 2015 16:16:40 +0900
From:	Chanwoo Choi <cw00.choi@...sung.com>
To:	myungjoo.ham@...sung.com
Cc:	"edubezval@...il.com" <edubezval@...il.com>,
	"rui.zhang@...el.com" <rui.zhang@...el.com>,
	박경민 <kyungmin.park@...sung.com>,
	"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
	"khilman@...aro.org" <khilman@...aro.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	대인기 <inki.dae@...sung.com>,
	Lukasz Majewski <l.majewski@...sung.com>,
	김국진 <kgene.kim@...sung.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RFC PATCH 0/2] thermal: Add generic devfreq cooling device

Dear Myungjoo,

On 07/17/2015 03:40 PM, MyungJoo Ham wrote:
>>   
>>  This patchset introduce the generic devfreq cooling device for generic thermal
>> framework. The devfreq devices are used ad cooling device to reduce the
>> overheating temperature. This patch is based on drivers/thermal/cpu_cooling.c.
>> The devfreq cooling device can change the ragne of the frequency table of
>> devfreq device according to cooling level in device tree file.
> 
> Hi,
> 
> 
> 1. You've exported "update_devfreq()" in 1/2 and didn't use it anywhere.
> 2. If you've added "update_devfreq()" to notify devfreq driver when a new
>  max/min is defined, you'll need to add it at set_state, OR
>    You may do it with opp_enable()/opp_disable() function and let opp
>  notifiers do the homework for you. (no need to update_devfreq().

It is my mistake. The devfreq_set_cur_state() in patch2 use the update_devfreq()
to change the maximum frequency of devfreq device as following:

+       /* Set the limited frequency to maximum frequency of devfreq */
+       devfreq_dev->devfreq->max_freq = limited_freq;
+       update_devfreq(devfreq_dev->devfreq);

I'll resent v2 patch-set.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/