[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAGWqDJ7kG9Q+LMnt3qhMh5nQc32uLNWPbhOULrtQoiedtbCpLg@mail.gmail.com>
Date: Fri, 17 Jul 2015 12:46:58 +0530
From: Vinay Simha <simhavcs@...il.com>
To: Joe Perches <joe@...ches.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Teddy Wang <teddy.wang@...iconmotion.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER"
<linux-fbdev@...r.kernel.org>,
"open list:STAGING SUBSYSTEM" <devel@...verdev.osuosl.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sm750fb: coding style fixes lines over 80 chars
#if 0, but it's also obviously incorrect
It supposed to be some tag #ifdef CONFIG_** .
Could anybody in the loop can reply?
i was just checking on style checks.
Will skip this file , will take up later
On Thu, Jul 16, 2015 at 9:27 AM, Joe Perches <joe@...ches.com> wrote:
> On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote:
>> scripts/checkpatch.pl kernel coding style fixes of WARNING
>
> Please don't be a checkpatch robot.
>
> Use tools to prompt your brain, but don't ever turn
> your brain off.
>
>> diff --git a/drivers/staging/sm750fb/ddk750_help.h b/drivers/staging/sm750fb/ddk750_help.h
>
>
>> +/* if 718 big endian turned on,be aware that don't use this driver for general
>> + use,only for ppc big-endian */
>> +#warning "big endian on target cpu and enable nature big endian support of 718
>> + capability !"
>
> Yes, this if #if 0, but it's also obviously incorrect
>
> I didn't look at the rest.
>
>
--
Regards,
Vinay Simha.B.N.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists