linux-kernel - Re: [RFC PATCH 5/6] bpf: Implement function bpf_read_pmu() that get the selected hardware PMU conuter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717110541.GJ12596@twins.programming.kicks-ass.net>
Date:	Fri, 17 Jul 2015 13:05:41 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	kaixu xia <xiakaixu@...wei.com>
Cc:	ast@...mgrid.com, davem@...emloft.net, acme@...nel.org,
	mingo@...hat.com, masami.hiramatsu.pt@...achi.com,
	jolsa@...nel.org, wangnan0@...wei.com,
	linux-kernel@...r.kernel.org, pi3orama@....com, hekuang@...wei.com
Subject: Re: [RFC PATCH 5/6] bpf: Implement function bpf_read_pmu() that get
 the selected hardware PMU conuter

On Fri, Jul 17, 2015 at 06:43:35PM +0800, kaixu xia wrote:
> The function bpf_read_pmu() can get the specific map key, convert
> the corresponding map value to the pointer to struct perf_event and
> return the Hardware PMU counter value.

Thanks for having me on Cc :/

> Signed-off-by: kaixu xia <xiakaixu@...wei.com>
> ---
> +static u64 bpf_read_pmu(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
> +{
> +	void *value = (void *) (unsigned long) r1;
> +	struct perf_event *event;
> +	u64 count;
> +
> +	if (!value || !(*(unsigned long *)value))
> +		return 0;
> +
> +	event = (struct perf_event *)(*(unsigned long *)value);
> +
> +	if (event->state == PERF_EVENT_STATE_ACTIVE)
> +		event->pmu->read(event);
> +
> +	count = local64_read(&event->count);
> +
> +	return count;
> +}

Hell no, that's way broken.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/