linux-kernel - Re: [PATCH 3/3] mm, meminit: Allow early_pfn_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150717132922.GN19282@twins.programming.kicks-ass.net>
Date:	Fri, 17 Jul 2015 15:29:22 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Mel Gorman <mgorman@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Nicolai Stange <nicstange@...il.com>,
	Dave Hansen <dave.hansen@...el.com>,
	Alex Ng <alexng@...rosoft.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	Linux-MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] mm, meminit: Allow early_pfn_to_nid to be used
 during runtime

On Fri, Jul 17, 2015 at 02:17:29PM +0100, Mel Gorman wrote:
> On Fri, Jul 17, 2015 at 03:12:32PM +0200, Peter Zijlstra wrote:
> > On Fri, Jul 17, 2015 at 01:22:04PM +0100, Mel Gorman wrote:
> > >  int __meminit early_pfn_to_nid(unsigned long pfn)
> > >  {
> > > +	static DEFINE_SPINLOCK(early_pfn_lock);
> > >  	int nid;
> > >  
> > > -	/* The system will behave unpredictably otherwise */
> > > -	BUG_ON(system_state != SYSTEM_BOOTING);
> > > +	/* Avoid locking overhead during boot but hotplug must lock */
> > > +	if (system_state != SYSTEM_BOOTING)
> > > +		spin_lock(&early_pfn_lock);
> > >  
> > >  	nid = __early_pfn_to_nid(pfn, &early_pfnnid_cache);
> > > -	if (nid >= 0)
> > > -		return nid;
> > > -	/* just returns 0 */
> > > -	return 0;
> > > +	if (nid < 0)
> > > +		nid = 0;
> > > +
> > > +	if (system_state != SYSTEM_BOOTING)
> > > +		spin_unlock(&early_pfn_lock);
> > > +
> > > +	return nid;
> > >  }
> > 
> > Why the conditional locking?
> 
> Unnecessary during boot when it's inherently serialised. The point of
> the deferred initialisation was to boot as quickly as possible.

Sure, but does it make a measurable difference?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/