linux-kernel - Re: [PATCH v4 09/19] drivers: base: Add MSI domain support for non-PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55ACA936.3060800@arm.com>
Date:	Mon, 20 Jul 2015 08:54:30 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	"majun (F)" <majun258@...wei.com>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Jiang Liu <jiang.liu@...ux.intel.com>,
	Jason Cooper <jason@...edaemon.net>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Yijing Wang <wangyijing@...wei.com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Duc Dang <dhdang@....com>
Subject: Re: [PATCH v4 09/19] drivers: base: Add MSI domain support for non-PCI
 devices

On 20/07/15 03:33, majun (F) wrote:
> 
> 
> 在 2015/7/15 20:16, Marc Zyngier 写道:
>> With the msi_list and the msi_domain properties now being at the
>> generic device level, it is starting to be relatively easy to offer
>> a generic way of providing non-PCI MSIs.
>>
> [...]
>> diff --git a/include/linux/msi.h b/include/linux/msi.h
>> index c10ec56..b55cf63 100644
>> --- a/include/linux/msi.h
>> +++ b/include/linux/msi.h
>> @@ -18,6 +18,11 @@ struct pci_dev;
>>  void __get_cached_msi_msg(struct msi_desc *entry, struct msi_msg *msg);
>>  void get_cached_msi_msg(unsigned int irq, struct msi_msg *msg);
>>  
>> +typedef void (*irq_write_msi_msg_t)(struct msi_desc *desc,
>> +				    struct msi_msg *msg);
>> +
>> +struct platform_msi_priv_data;
>> +
>>  struct msi_desc {
>>  	struct list_head		list;
>>  	unsigned int			irq;
>> @@ -42,6 +47,10 @@ struct msi_desc {
>>  				void __iomem *mask_base;
>>  			};
>>  		};
>> +		struct {
>> +			struct platform_msi_priv_data *platform_msi_priv_data;
>> +			u16 msi_index;
>> +		};
>>  	};
>>  };
>>  
> When I add this patch in linux 4.2.rc2, this part is rejected. So I added this part
> myself. But there is compiling errors.

[...]

Did you read this crucial part of the cover letter:

<quote>
[...]
Patches are on top of 4.2-rc2 and Jiang Liu's series, and available at:

git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git
irq/npci-msi-v2
</quote>

Without Jiang Liu's series as a prerequisite, it is not surprising
nothing applies, let alone compile...

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/