| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jul 2015 16:23:57 +0200 From: Daniel Vetter <daniel@...ll.ch> To: Sudip Mukherjee <sudipm.mukherjee@...il.com> Cc: Chris Wilson <chris@...is-wilson.co.uk>, Daniel Vetter <daniel.vetter@...el.com>, Jani Nikula <jani.nikula@...ux.intel.com>, David Airlie <airlied@...ux.ie>, intel-gfx@...ts.freedesktop.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: fix possible null pointer dereference On Mon, Jul 20, 2015 at 06:58:32PM +0530, Sudip Mukherjee wrote: > On Mon, Jul 20, 2015 at 01:38:46PM +0100, Chris Wilson wrote: > > On Mon, Jul 20, 2015 at 05:59:29PM +0530, Sudip Mukherjee wrote: > > > We were dereferencing dev first and then checking if it is NULL. Lets > > > check for NULL first and then dereference. > > > > The code is bonkers. Testing for a lack of a correctly constructed > > debugfs seq_file inside the debugfs seq_file callback is inane. > I missed seeing before sending this patch that there are some more > places where this has been done. > Then are you suggesting to remove the test? It's all been added for the tp validation support. And yes it should be removed everywhere. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists