linux-kernel - Re: [PATCH] staging: fix to match 80-char rule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20150720200903.GB5270@lynx>
Date:	Mon, 20 Jul 2015 22:09:15 +0200
From:	Mario Bambagini <mario.bambagini@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	mario.bambagini@...il.com, marek.belisko@...il.com,
	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fix to match 80-char rule

On Sun, Jul 19, 2015 at 12:28:01PM -0700, Joe Perches wrote:
> On Sun, 2015-07-19 at 20:41 +0200, Mario Bambagini wrote:
> > Fixed comment line to match the 80-char rules.
> > The line contained 81 characters.
> > The file is fully compliant with the code style, now.
> > 
> > Signed-off-by: Mario Bambagini <mario.bambagini@...il.com>
> > ---
> >  drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> > index e5cc5be..931e45e 100644
> > --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> > +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> > @@ -24,7 +24,7 @@
> >    License along with this program; if not, write to the
> >    Free Software Foundation, Inc., 59 Temple Place -
> >    Suite 330, Boston, MA 02111-1307, USA.
> > -  -----------------------------------------------------------------------------*/
> > +  ----------------------------------------------------------------------------*/
> 
> Perhaps it'd be nicer to use the normal comment block style
> 
> /*
>  * <comment>
>  * <comment>
>  */
> 
> Something like:
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c | 56 ++++++++++++------------
>  1 file changed, 29 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> index e5cc5be..fc7d19f 100644
> --- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> +++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_cs.c
> @@ -1,30 +1,32 @@
> -/*---------------------------------------------------------------------------
> -  FT1000 driver for Flarion Flash OFDM NIC Device
> -
> -  Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
> -  Copyright (C) 2002 Flarion Technologies, All rights reserved.
> -  Copyright (C) 2006 Patrik Ostrihon, All rights reserved.
> -  Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved.
> -
> -  The initial developer of the original code is David A. Hinds
> -  <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds.
> -
> -  This file was modified to support the Flarion Flash OFDM NIC Device
> -  by Wai Chan (w.chan@...rion.com).
> -
> -  Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@....sk)
> -
> -  This program is free software; you can redistribute it and/or modify it
> -  under the terms of the GNU General Public License as published by the Free
> -  Software Foundation; either version 2 of the License, or (at your option) any
> -  later version. This program is distributed in the hope that it will be useful,
> -  but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
> -  or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> -  more details. You should have received a copy of the GNU General Public
> -  License along with this program; if not, write to the
> -  Free Software Foundation, Inc., 59 Temple Place -
> -  Suite 330, Boston, MA 02111-1307, USA.
> -  -----------------------------------------------------------------------------*/
> +/*
> + *  FT1000 driver for Flarion Flash OFDM NIC Device
> + *
> + * Copyright (C) 1999 David A. Hinds.  All Rights Reserved.
> + * Copyright (C) 2002 Flarion Technologies, All rights reserved.
> + * Copyright (C) 2006 Patrik Ostrihon, All rights reserved.
> + * Copyright (C) 2006 ProWeb Consulting, a.s, All rights reserved.
> + *
> + * The initial developer of the original code is David A. Hinds
> + * <dahinds@...rs.sourceforge.net>.  Portions created by David A. Hinds.
> + *
> + * This file was modified to support the Flarion Flash OFDM NIC Device
> + * by Wai Chan (w.chan@...rion.com).
> + *
> + * Port for kernel 2.6 created by Patrik Ostrihon (patrik.ostrihon@....sk)
> + *
> + * This program is free software; you can redistribute it and/or modify it
> + * under the terms of the GNU General Public License as published by the
> + * Free Software Foundation; either version 2 of the License, or (at your
> + * option) any later version.
> + *
> + * This program is distributed in the hope it will be useful, but WITHOUT
> + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
> + * more details.
> + *
> + * You should have received a copy of the GNU General Public License along with
> + * this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
>  
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> 
> 

I agree, the normal comment is far better.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/