linux-kernel - Re: [PATCH v1 3/7] input: cyapa: add proximity function support for gen5 and gen6 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150721000658.GD15528@dtor-ws>
Date:	Mon, 20 Jul 2015 17:06:58 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Dudley Du <dudl@...ress.com>
Cc:	mark.rutland@....com, robh+dt@...nel.org, rydberg@...omail.se,
	bleung@...gle.com, jmmahler@...il.com, devicetree@...r.kernel.org,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/7] input: cyapa: add proximity function support for
 gen5 and gen6 modules

Hi Dudley,

On Mon, Jun 15, 2015 at 05:01:33PM +0800, Dudley Du wrote:
>  
> +static void cyapa_pip_report_proximity(struct cyapa *cyapa,
> +		const struct cyapa_pip_report_data *report_data)
> +{
> +	struct input_dev *input = cyapa->input;
> +	u8 distance = report_data->report_head[PIP_PROXIMITY_DISTANCE_OFFSET] &
> +			PIP_PROXIMITY_DISTANCE_MASK;
> +
> +	input_report_abs(input, ABS_MT_DISTANCE, distance);
> +	input_sync(input);

It looks like the distance reported by the hardware is not per-contact
(i.e. it can not tell that we had 2 fingers on surface and the 2nd one
was lifted and is now hovering over the surface), so we should be using
ABS_DISTANCE, not ABS_MT_DISTANCE.

I can adjust it here, no need to resend.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/