linux-kernel - Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 11:59:46 +0000 (GMT)
From:	Maninder Singh <maninder1.s@...sung.com>
To:	Kalle Valo <kvalo@....qualcomm.com>
Cc:	"ath10k@...ts.infradead.org" <ath10k@...ts.infradead.org>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	PANKAJ MISHRA <pankaj.m@...sung.com>
Subject: Re: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel

>> chandef is initialized with NULL and on the very next line,
>> we are using it to get channel, which is not correct.
>>
>> channel should be initialized after obtaining chandef.
>>
>> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>

>How did you find this bug?

Static anlysis reports this bug like coverity or any other static tool like cppcheck :-

drivers/net/wireless/ath/ath10k/mac.c:839]: (error) Possible null pointer dereference: chandef

Thanks,
Maninder