linux-kernel - Re: [PATCH/RFC 03/51] leds: Add an internal led_set_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55AE68A0.3080903@gmail.com>
Date:	Tue, 21 Jul 2015 17:43:28 +0200
From:	Jacek Anaszewski <jacek.anaszewski@...il.com>
To:	Pavel Machek <pavel@....cz>,
	Jacek Anaszewski <j.anaszewski@...sung.com>
CC:	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	cooloney@...il.com, rpurdie@...ys.net, stsp@...rs.sourceforge.net,
	Andrew Lunn <andrew@...n.ch>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH/RFC 03/51] leds: Add an internal led_set_brightness_nosleep
 function



On 21.07.2015 11:53, Pavel Machek wrote:
>
>>   	/* Set LED brightness level */
>> -	/* Must not sleep, use a workqueue if needed */
>> +	/* Must not sleep if the driver sets LED_BRIGHTNESS_FAST flag */
>>   	void		(*brightness_set)(struct led_classdev *led_cdev,
>>   					  enum led_brightness brightness);
>>   	/*
>
> Have fun improving static checkers to check for this kind of crazy
> semantics.

I'd be grateful if you gave an example of the tool that would
complain about it.

> NAK.
>
> Just use two callbacks, one of them always NULL.
> 									Pavel
>

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/