linux-kernel - Re: [PATCH/RFC 03/51] leds: Add an internal led_set_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150721213027.GA14670@amd>
Date:	Tue, 21 Jul 2015 23:30:28 +0200
From:	Pavel Machek <pavel@....cz>
To:	Jacek Anaszewski <jacek.anaszewski@...il.com>
Cc:	Jacek Anaszewski <j.anaszewski@...sung.com>,
	linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	cooloney@...il.com, rpurdie@...ys.net, stsp@...rs.sourceforge.net,
	Andrew Lunn <andrew@...n.ch>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH/RFC 03/51] leds: Add an internal
 led_set_brightness_nosleep function

On Tue 2015-07-21 17:43:28, Jacek Anaszewski wrote:
> 
> 
> On 21.07.2015 11:53, Pavel Machek wrote:
> >
> >>  	/* Set LED brightness level */
> >>-	/* Must not sleep, use a workqueue if needed */
> >>+	/* Must not sleep if the driver sets LED_BRIGHTNESS_FAST flag */
> >>  	void		(*brightness_set)(struct led_classdev *led_cdev,
> >>  					  enum led_brightness brightness);
> >>  	/*
> >
> >Have fun improving static checkers to check for this kind of crazy
> >semantics.
> 
> I'd be grateful if you gave an example of the tool that would
> complain about it.

I'd be grateful if you would go through all the tools and check that
this does _not_ break them. Because what you are doing is quite crazy.

Start with lockdep.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/