linux-kernel - Re: [PATCH 4.0 00/58] 4.0.9-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jul 2015 13:13:27 -0400
From:	Donald Parsons <dparsons@...ghtdsl.net>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 4.0 00/58] 4.0.9-stable review

Greg,

The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
Jul 13 18:08:30 EDT 2015 x86_64      Fedora 14)

This mis-compile was fixed in 4.1-rc8.  The diff was:

diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
linux-4.1-rc8/arch/x86/kvm/mmu.c
--- linux-4.1-rc7/arch/x86/kvm/mmu.c	2015-07-15 00:05:34.000000000 -0400
+++ linux-4.1-rc8/arch/x86/kvm/mmu.c	2015-07-15 00:07:45.000000000 -0400
@@ -4215,13 +4215,13 @@
 	u64 entry, gentry, *spte;
 	int npte;
 	bool remote_flush, local_flush, zap_page;
-	union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
-		.cr0_wp = 1,
-		.cr4_pae = 1,
-		.nxe = 1,
-		.smep_andnot_wp = 1,
-		.smap_andnot_wp = 1,
-	};
+	union kvm_mmu_page_role mask = { };
+
+	mask.cr0_wp = 1;
+	mask.cr4_pae = 1;
+	mask.nxe = 1;
+	mask.smep_andnot_wp = 1;
+	mask.smap_andnot_wp = 1;
 
 	/*
 	 * If we don't have indirect shadow pages, it means no page is


Please add to linux-4.0.9 so older compilers will work.

Thanks,
Don Parsons

PS: Compile error is :

CC [M]  arch/x86/kvm/mmu.o
arch/x86/kvm/mmu.c: In function kvm_mmu_pte_write:
arch/x86/kvm/mmu.c:4219:3: error: unknown field cr0_wp specified
in initializer
arch/x86/kvm/mmu.c:4220:3: error: unknown field cr4_pae specified
in initializer
arch/x86/kvm/mmu.c:4220:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4220:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4221:3: error: unknown field nxe specified in
initializer
arch/x86/kvm/mmu.c:4221:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4221:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4222:3: error: unknown field smep_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4222:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4222:3: warning: (near initialization for
(anonymous))
arch/x86/kvm/mmu.c:4223:3: error: unknown field smap_andnot_wp
specified in initializer
arch/x86/kvm/mmu.c:4223:3: warning: excess elements in union initializer
arch/x86/kvm/mmu.c:4223:3: warning: (near initialization for
(anonymous))
make[2]: *** [arch/x86/kvm/mmu.o] Error 1
make[1]: *** [arch/x86/kvm] Error 2
make: *** [arch/x86] Error 2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/