linux-kernel - Re: [PATCH 4.0 00/58] 4.0.9-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150721181358.GA20131@kroah.com>
Date:	Tue, 21 Jul 2015 11:13:58 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Donald Parsons <dparsons@...ghtdsl.net>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.0 00/58] 4.0.9-stable review

On Tue, Jul 21, 2015 at 01:13:27PM -0400, Donald Parsons wrote:
> Greg,
> 
> The kernel still does not compile with gcc-4.5.1 since linux-4.0.5 when
> a kvm back-port from 4.1-rc5 went in.  (This is on Linux 4.1.2 SMP Mon
> Jul 13 18:08:30 EDT 2015 x86_64      Fedora 14)
> 
> This mis-compile was fixed in 4.1-rc8.  The diff was:
> 
> diff -ur linux-4.1-rc7/arch/x86/kvm/mmu.c
> linux-4.1-rc8/arch/x86/kvm/mmu.c
> --- linux-4.1-rc7/arch/x86/kvm/mmu.c	2015-07-15 00:05:34.000000000 -0400
> +++ linux-4.1-rc8/arch/x86/kvm/mmu.c	2015-07-15 00:07:45.000000000 -0400
> @@ -4215,13 +4215,13 @@
>  	u64 entry, gentry, *spte;
>  	int npte;
>  	bool remote_flush, local_flush, zap_page;
> -	union kvm_mmu_page_role mask = (union kvm_mmu_page_role) {
> -		.cr0_wp = 1,
> -		.cr4_pae = 1,
> -		.nxe = 1,
> -		.smep_andnot_wp = 1,
> -		.smap_andnot_wp = 1,
> -	};
> +	union kvm_mmu_page_role mask = { };
> +
> +	mask.cr0_wp = 1;
> +	mask.cr4_pae = 1;
> +	mask.nxe = 1;
> +	mask.smep_andnot_wp = 1;
> +	mask.smap_andnot_wp = 1;
>  
>  	/*
>  	 * If we don't have indirect shadow pages, it means no page is
> 
> 
> Please add to linux-4.0.9 so older compilers will work.

What is the commit id in Linus's tree that resolves this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/