linux-kernel - Re: [PATCH] cpufreq: Drop unnecessary arguments from two functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 22 Jul 2015 12:16:48 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Linux PM list <linux-pm@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpufreq: Drop unnecessary arguments from two functions

On 22-07-15, 04:09, Rafael J. Wysocki wrote:
>  static int cpufreq_remove_dev(struct device *dev, struct subsys_interface *sif)
>  {
>  	unsigned int cpu = dev->id;
> +	struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
>  	int ret;
>  
>  	/*
> @@ -1530,7 +1525,6 @@ static int cpufreq_remove_dev(struct dev
>  	 * link or free policy here.
>  	 */
>  	if (cpu_is_offline(cpu)) {
> -		struct cpufreq_policy *policy = per_cpu(cpufreq_cpu_data, cpu);
>  		struct cpumask mask;
>  
>  		if (!policy)
> @@ -1547,17 +1541,18 @@ static int cpufreq_remove_dev(struct dev
>  			remove_cpu_dev_symlink(policy, cpu);
>  			return 0;
>  		}
> +	} else {
> +		ret = __cpufreq_remove_dev_prepare(dev);
> +		if (!ret)
> +			ret = __cpufreq_remove_dev_finish(dev);
>  
> -		cpufreq_policy_free(policy, true);
> -		return 0;
> +		/* The CPU is online, so the policy cannot be inactive here. */
> +		if (ret)
> +			return ret;
>  	}
>  
> -	ret = __cpufreq_remove_dev_prepare(dev, sif);
> -
> -	if (!ret)
> -		ret = __cpufreq_remove_dev_finish(dev, sif);
> -
> -	return ret;
> +	cpufreq_policy_free(policy, true);

You need to check for policy_is_inactive(policy) before freeing
policy. cpufreq_remove_dev() will be called one by one for all CPUs of
a policy ..

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/