linux-kernel - Re: [PATCH] qla2xxx: remove unused rval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D1D5644B.A614D%himanshu.madhani@qlogic.com>
Date:	Wed, 22 Jul 2015 22:17:24 +0000
From:	Himanshu Madhani <himanshu.madhani@...gic.com>
To:	Spencer Baugh <sbaugh@...ern.com>,
	Chad Dupuis <chad.dupuis@...gic.com>,
	Giridhar Malavali <giridhar.malavali@...gic.com>,
	Saurav Kashyap <saurav.kashyap@...gic.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
CC:	Joern Engel <joern@...estorage.com>,
	Spencer Baugh <Spencer.baugh@...estorage.com>,
	Joern Engel <joern@...fs.org>
Subject: Re: [PATCH] qla2xxx: remove unused rval


On 7/22/15, 3:08 PM, "Spencer Baugh" <sbaugh@...ern.com> wrote:

>From: Joern Engel <joern@...fs.org>
>
>We don't touch the return value of qla2x00_loop_resync in
>qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
>
>Signed-off-by: Joern Engel <joern@...fs.org>
>Signed-off-by: Spencer Baugh <sbaugh@...ern.com>
>---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>index a28815b..b9ee115 100644
>--- a/drivers/scsi/qla2xxx/qla_os.c
>+++ b/drivers/scsi/qla2xxx/qla_os.c
>@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct
>work_struct *work)
> static int
> qla2x00_do_dpc(void *data)
> {
>-	int		rval;
> 	scsi_qla_host_t *base_vha;
> 	struct qla_hw_data *ha;
> 
>@@ -5025,7 +5024,7 @@ loop_resync_check:
> 			if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
> 			    &base_vha->dpc_flags))) {
> 
>-				rval = qla2x00_loop_resync(base_vha);
>+				qla2x00_loop_resync(base_vha);
> 
> 				clear_bit(LOOP_RESYNC_ACTIVE,
> 						&base_vha->dpc_flags);
>-- 
>2.5.0.rc3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Acked-by: Himanshu Madhani <himanshu.madhani@...gic.com>


>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/