linux-kernel - RE: [PATCH 1/4] serial: 8250_dw: Add support for big-endian MMIO accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB4PR02MB272E79444E7C044767FEF22D6820@DB4PR02MB272.eurprd02.prod.outlook.com>
Date:	Thu, 23 Jul 2015 06:15:14 +0000
From:	Noam Camus <noamc@...hip.com>
To:	Peter Hurley <peter@...leysoftware.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"Alexey.Brodkin@...opsys.com" <Alexey.Brodkin@...opsys.com>,
	"vgupta@...opsys.com" <vgupta@...opsys.com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.com" <jslaby@...e.com>
Subject: RE: [PATCH 1/4] serial: 8250_dw: Add support for big-endian MMIO
 accesses

From: Peter Hurley [mailto:peter@...leysoftware.com] 
Sent: Wednesday, July 22, 2015 3:41 PM

>> diff --git a/drivers/tty/serial/8250/8250_dw.c 
>> b/drivers/tty/serial/8250/8250_dw.c
>> index d48b506..fe0b487 100644
>> --- a/drivers/tty/serial/8250/8250_dw.c
>> +++ b/drivers/tty/serial/8250/8250_dw.c
>> @@ -173,15 +173,13 @@ static void dw8250_serial_outq(struct uart_port 
>> *p, int offset, int value)  }  #endif /* CONFIG_64BIT */
>>  
>> -static void dw8250_serial_out32(struct uart_port *p, int offset, int 
>> value)
>> +static void dw8250_check_control(struct uart_port *p, int offset, 
>> +int value)

> Also, I think this fn name should be dw8250_check_LCR() to distinguish it from modem control.

No problem will rename in my v2