Message-ID: <CANk3uyDVj-UHpxpEkvtC+DrKERS5MsLbxdBCCJGPiA+VQoP0Tw@mail.gmail.com>
Date:	Fri, 24 Jul 2015 16:18:22 +0800
From:	Jianwei Wang <jianwei.wang.chn@...il.com>
To:	jianwei wang <jianwei.wang.chn@...il.com>,
	dri-devel@...ts.freedesktop.org, airlied@...ux.ie,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org,
	姚智情 <mark.yao@...k-chips.com>,
	scottwood@...escale.com, Thierry Reding <thierry.reding@...il.com>,
	Alison Wang <b18965@...escale.com>,
	Xiubo Li <lixiubo@...s.chinamobile.com>
Cc:	Daniel Vetter <daniel.vetter@...ll.ch>
Subject: Re: [PATCH v11 1/5] drm/layerscape: Add Freescale DCU DRM driver

On Fri, Jul 24, 2015 at 3:48 PM, Daniel Vetter <daniel@...ll.ch> wrote:
> On Fri, Jul 24, 2015 at 11:21:57AM +0800, jianwei wang wrote:
>> Hi Dave,
>>
>> I think Freescale DCU DRM driver is ready now, can it land?
>>
>> I have worked on this driver for about nine month. Daniel Vetter,
>> Thierry Reding, Mark yao,
>> Alexander Stein, Paul Bolle, Alison Wang, Stefan Agner reviewed this
>> pathset. The latest
>> version v11 has been send out about an week, and no more comments any more.
>
> On a quick look about overall process there's a few bits missing still:
> - review from dt maintainer for the device-tree pieces (review from an
>   original author like Alice Wang doesn't count).
> - needs one patch for MAINTAINER entry for drm/layerscape.
> - just send a pull request to Dave once you have this all.
>
> Cheers, Daniel

Okay, Thanks!

BR.
Jianwei

>>
>> BR.
>> Jianwei
>>
>> On Mon, Jul 20, 2015 at 5:53 PM, Jianwei Wang
>> <jianwei.wang.chn@...il.com> wrote:
>> > This patch add support for Two Dimensional Animation and Compositing
>> > Engine (2D-ACE) on the Freescale SoCs.
>> >
>> > 2D-ACE is a Freescale display controller. 2D-ACE describes
>> > the functionality of the module extremely well its name is a value
>> > that cannot be used as a token in programming languages.
>> > Instead the valid token "DCU" is used to tag the register names and
>> > function names.
>> >
>> > The Display Controller Unit (DCU) module is a system master that
>> > fetches graphics stored in internal or external memory and displays
>> > them on a TFT LCD panel. A wide range of panel sizes is supported
>> > and the timing of the interface signals is highly configurable.
>> > Graphics are read directly from memory and then blended in real-time,
>> > which allows for dynamic content creation with minimal CPU
>> > intervention.
>> >
>> > The features:
>> > (1) Full RGB888 output to TFT LCD panel.
>> > (2) Blending of each pixel using up to 4 source layers
>> > dependent
>> > on size of panel.
>> > (3) Each graphic layer can be placed with one pixel resolution
>> > in either axis.
>> > (4) Each graphic layer support RGB565 and RGB888 direct colors
>> > without alpha channel and BGRA8888 BGRA4444 ARGB1555 direct
>> > colors
>> > with an alpha channel and YUV422 format.
>> > (5) Each graphic layer support alpha blending with 8-bit
>> > resolution.
>> >
>> > This is a simplified version, only one primary plane, one
>> > framebuffer, one crtc, one connector and one encoder for TFT
>> > LCD panel.
>> >
>> > Signed-off-by: Alison Wang <b18965@...escale.com>
>> > Signed-off-by: Xiubo Li <lixiubo@...s.chinamobile.com>
>> > Signed-off-by: Jianwei Wang <jianwei.wang.chn@...il.com>
>> > Acked-by: Daniel Vetter <daniel.vetter@...ll.ch>
>> > Reviewed-by: Alison Wang <alison.wang@...escale.com>
>> > ---
>> >
>> >
>> > Changed in V11
>> > -set regmap_config.cache_type to REGCACHE_FLAT
>> > Advanced by Alexander Stein
>> >
>> > Changed in V10
>> > -adjust commit log, remove meaningless statement
>> > -cleanup code for it's format and style.
>> > -remove platform related code out, including of tcon(vf610) and scfg(ls1021a)
>> > -remove useless sentences: encoder->crtc = crtc; and connector->encoder = encoder; and so on
>> > -add vendor prefix for panel pandle
>> > -make a DCU_CTRLDESCLN(x, y)  to avoid high repetition
>> > -introduce per-SoC capability structure to avoid check on the OF node's compatible string
>> > -Implement some functions: crtc enable and disable, enable and disable VBLANK, plane atomic_disable and atomic_enable -atomic_check and so on
>> > -move DCU config sentence to the right place
>> > -move get resources functions to  ->probe()
>> > -move fsl,dcu.txt to video/ folder
>> > -add big-endian describe
>> > All advaced by Thierry Reding
>> >
>> > Changed in V9
>> >
>> > -put node after calling of_drm_find_panel
>> > -split clk_prepare_enable() to clk_prepare() and clk_enable(), just call clk_prepare once, and check return value
>> > -check regmap_write/regmap_read return return value
>> > -remove useless ".owner    = THIS_MODULE,"
>> > All advanced by Mark Yao
>> >
>> > Changed in V8
>> >
>> > - Remove useless code
>> >  #define DRIVER_NAME     "fsl-dcu-drm"
>> >  MODULE_ALIAS("platform:fsl-dcu-drm");
>> > Adviced by Paul Bolle
>> >
>> > Changed in V7
>> >
>> > - Remove redundant functions and replace deprecated hooker
>> > Adviced by Daniel Vetter
>> > - Replace drm_platform_init with drm_dev_alloc/register
>> > Adviced by Daniel Vetter
>> >
>> > Changed in V6
>> >
>> > - Add NEC nl4827hc19_05b panel to panel-simple.c
>> > Adviced by Mark Yao
>> > - Add DRIVER_ATOMIC for driver_features
>> > Adviced by Mark Yao
>> > - check fsl_dev if it's NULL at PM suspend/resume
>> > Adviced by Mark Yao
>> >
>> > Changed in V5
>> >
>> > - Update commit message
>> > - Add layer registers initialization
>> > - Remove unused functions
>> > - Rename driver folder
>> > Adviced by Stefan Agner
>> > - Move pixel clock control functions to fsl_dcu_drm_drv.c
>> > - remove redundant enable the clock implicitly using regmap
>> > - Add maintainer message
>> >
>> > Changed in V4:
>> >
>> > -This version doesn't have functionality changed
>> > Just a minor adjustment.
>> >
>> > Changed in V3:
>> >
>> > - Test driver on Vybrid board and add compatible string
>> > - Remove unused functions
>> > - set default crtc for encoder
>> > - replace legacy functions with atomic help functions
>> > Adviced by Daniel Vetter
>> > - Set the unique name of the DRM device
>> > - Implement irq handle function for vblank interrupt
>> >
>> > Changed in v2:
>> > - Add atomic support
>> > Adviced by Daniel Vetter
>> > - Modify bindings file
>> > - Rename node for compatibility
>> > - Move platform related code out for compatibility
>> > Adviced by Stefan Agner
>> >
>> >
>> >  .../devicetree/bindings/video/fsl,dcu.txt          |  22 ++
>> >  MAINTAINERS                                        |   8 +
>> >  drivers/gpu/drm/Kconfig                            |   2 +
>> >  drivers/gpu/drm/Makefile                           |   1 +
>> >  drivers/gpu/drm/fsl-dcu/Kconfig                    |  18 +
>> >  drivers/gpu/drm/fsl-dcu/Makefile                   |   7 +
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c         | 208 +++++++++++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.h         |  19 +
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c          | 403 +++++++++++++++++++++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h          | 197 ++++++++++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_fbdev.c        |  23 ++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c          |  43 +++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h       |  33 ++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c        | 261 +++++++++++++
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h        |  17 +
>> >  drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c          | 182 ++++++++++
>> >  16 files changed, 1444 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/video/fsl,dcu.txt
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/Kconfig
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/Makefile
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.h
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.h
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_fbdev.c
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_kms.c
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_output.h
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.c
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_plane.h
>> >  create mode 100644 drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c
>> >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists