linux-kernel - Re: [PATCH v2 2/2] ARM: sunxi: dt: Convert users to the PIO interrupts binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYT0gsrZZcWrkES4EdF0G1oY_t0isOTbJtbCGx2KP2HTw@mail.gmail.com>
Date:	Mon, 27 Jul 2015 14:58:29 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:	Hans de Goede <hdegoede@...hat.com>, Chen-Yu Tsai <wens@...e.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] ARM: sunxi: dt: Convert users to the PIO
 interrupts binding

On Mon, Jul 27, 2015 at 2:41 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:

> The current DTs were setting the cell size to 2, but used the default xlate
> function that was assuming an interrupt cell size of 1, leading to the
> second part of the cell (the flags) being ignored, while we were having an
> inconsistent binding between the interrupts and gpio (that could also be
> used as interrupts).
>
> That "binding" doesn't work either with newer SoCs that have multiple irq
> banks.
>
> Now that we fixed the pinctrl driver to handle this like it should always
> have been handled, convert the DT users, and while we're at it, remove the
> size-cells property of PIO that is completely useless.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Acked-by: Linus Walleij <linus.walleij@...aro.org>

I guess this will be merged through ARM SoC?

If you want me to carry it in pinctrl and you're *certain* it
will not collide with something else coming in from ARM SoC
then tell me ... prefer to even have ARM SoC maintainers
ACK on this actually.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/