linux-kernel - Re: [PATCH v2 2/2] ARM: sunxi: dt: Convert users to the PIO interrupts binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 28 Jul 2015 14:39:39 +0200
From:	Maxime Ripard <maxime.ripard@...e-electrons.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Hans de Goede <hdegoede@...hat.com>, Chen-Yu Tsai <wens@...e.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] ARM: sunxi: dt: Convert users to the PIO
 interrupts binding

On Mon, Jul 27, 2015 at 02:58:29PM +0200, Linus Walleij wrote:
> On Mon, Jul 27, 2015 at 2:41 PM, Maxime Ripard
> <maxime.ripard@...e-electrons.com> wrote:
> 
> > The current DTs were setting the cell size to 2, but used the default xlate
> > function that was assuming an interrupt cell size of 1, leading to the
> > second part of the cell (the flags) being ignored, while we were having an
> > inconsistent binding between the interrupts and gpio (that could also be
> > used as interrupts).
> >
> > That "binding" doesn't work either with newer SoCs that have multiple irq
> > banks.
> >
> > Now that we fixed the pinctrl driver to handle this like it should always
> > have been handled, convert the DT users, and while we're at it, remove the
> > size-cells property of PIO that is completely useless.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > Reviewed-by: Hans de Goede <hdegoede@...hat.com>
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> I guess this will be merged through ARM SoC?
> 
> If you want me to carry it in pinctrl and you're *certain* it
> will not collide with something else coming in from ARM SoC
> then tell me ... prefer to even have ARM SoC maintainers
> ACK on this actually.

I'll merge it through my tree (and then arm-soc).

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)