linux-kernel - Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11512207.BLTbrXTcg1@jclayton-pc>
Date:	Tue, 28 Jul 2015 10:49:52 -0700
From:	Joshua Clayton <stillcompiling@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Julia Lawall <julia.lawall@...6.fr>, devel@...verdev.osuosl.org,
	Florian Schilhabel <florian.c.schilhabel@...glemail.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Nitin Kuppelur <nitinkuppelur@...il.com>,
	linux-kernel@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [PATCH V3 RESEND 8/8] staging: rtl8712: change SupportedRates to rates

On Tuesday, July 28, 2015 06:56:38 PM Dan Carpenter wrote:
> On Tue, Jul 28, 2015 at 08:50:04AM -0700, Joshua Clayton wrote:
> > On Tuesday, July 28, 2015 05:37:16 PM Julia Lawall wrote:
> > > > diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > index 83d4bca..1ded691 100644
> > > > --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> > > > @@ -204,13 +204,13 @@ static inline char *translate_scan(struct _adapter *padapter,
> > > >  	/* Add the protocol name */
> > > >  	iwe.cmd = SIOCGIWNAME;
> > > >  	if ((r8712_is_cckratesonly_included(pnetwork->network.
> > > > -	     SupportedRates)) == true) {
> > > > +	     rates)) == true) {
> > > >  		if (ht_cap == true)
> > > >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
> > > >  		else
> > > >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
> > > >  	} else if ((r8712_is_cckrates_included(pnetwork->network.
> > > > -		    SupportedRates)) == true) {
> > > > +		    rates)) == true) {
> > > >  		if (ht_cap == true)
> > > >  			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");
> > > >  		else
> > > 
> > > The placement of the line breaks here is partucularly unpleasant.  Perhaps
> > > that could be adjusted now that the field name is shorter.  Theer may be
> > > some other cases in the patch where the line breaks could be adjusted to
> > > improve readability.
> > > 
> > > julia
> > I agree. Dan Carpenter earlier complained about me fixing up the lines
> > while changing the variable name. Should that be a separate patch?
> > 
> 
> Changing the line breaks here is a tiny change on the same line and so
> it's fine.  It fits into the one thing per patch rule.

This is the style I prefer (getting rid of the explicit == true)

-	if ((r8712_is_cckratesonly_included(pnetwork->network.
-	     SupportedRates)) == true) {
+	if (r8712_is_cckratesonly_included(pnetwork->network.rates)) {
 		if (ht_cap == true)
 			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bn");
 		else
 			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11b");
-	} else if ((r8712_is_cckrates_included(pnetwork->network.
-		    SupportedRates)) == true) {
+	} else if (r8712_is_cckrates_included(pnetwork->network.rates)) {
 		if (ht_cap == true)
 			snprintf(iwe.u.name, IFNAMSIZ, "IEEE 802.11bgn");

Does that look ok?
If we keep the "== true" and the extra set of parentheses, the "else if" case goes over 80 lines.
I will happily submit the change as follow up patch if that is too much to change at once. 
> 
> regards,
> dan carpenter
> 

-- 
~Joshua Clayton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/