linux-kernel - Re: [PATCH v1 7/7] ARM: dts: ifc6410: add inforce LVDS panel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55B7C0DC.2010501@suse.de>
Date:	Tue, 28 Jul 2015 19:50:20 +0200
From:	Andreas Färber <afaerber@...e.de>
To:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-arm-msm@...r.kernel.org
Cc:	agross@...eaurora.org, Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, Rob Clark <robdclark@...il.com>
Subject: Re: [PATCH v1 7/7] ARM: dts: ifc6410: add inforce LVDS panel support

Am 28.07.2015 um 14:54 schrieb Srinivas Kandagatla:
> This patch adds LVDS panel for IFC6410.
> 
> Signed-off-by: Rob Clark <robdclark@...il.com>
> [Rob Clark: WIP patch]
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---
>  arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 66 ++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> index 1ab71f1..3bdac02 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
> @@ -63,6 +63,12 @@
>  					qcom,switch-mode-frequency = <3200000>;
>  				};
>  
> +				pm8921_l2: l2 {
> +					regulator-min-microvolt = <1200000>;
> +					regulator-max-microvolt = <1200000>;
> +					bias-pull-down;
> +				};
> +
>  				pm8921_l3: l3 {
>  					regulator-min-microvolt = <3050000>;
>  					regulator-max-microvolt = <3300000>;
> @@ -96,6 +102,10 @@
>  				pm8921_lvs1: lvs1 {
>  					bias-pull-down;
>  				};
> +
> +				pm8921_lvs7: lvs7 {
> +					bias-pull-down;
> +				};
>  			};
>  		};
>  
> @@ -119,6 +129,41 @@
>  
>  		mdp: qcom,mdp@...0000 {
>  			status = "okay";
> +			qcom,lvds-panel = <&panel>;

In my testing this broke/uglified HDMI output. Since not everyone has
that LVDS panel attached, or might have a different panel type, I don't
think the panel node belongs in the generic -ifc6410.dts file.
I suggest you add an -ifc6410+inforce-lvds.dts or so for that.

> +			lvds-vccs-3p3v-supply = <&ext_3p3v>;
> +			lvds-pll-vdda-supply = <&pm8921_l2>;
> +			lvds-vdda-supply = <&pm8921_lvs7>;
> +		};
> +
> +		panel_3p3v: panel_3p3v {

s/_/-/ ?

> +			compatible = "regulator-fixed";
> +			pinctrl-0 = <&disp_en_gpios>;
> +			pinctrl-names = "default";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			regulator-name = "panel_en_3p3v";
> +			regulator-type = "voltage";
> +			startup-delay-us = <0>;
> +			gpio = <&pm8921_gpio 36 GPIO_ACTIVE_HIGH>;
> +			enable-active-high;
> +			regulator-boot-on;
> +		};
> +
> +		backlight: backlight{
> +			pinctrl-0 = <&pwm_bl_gpios>;
> +			pinctrl-names = "default";
> +			compatible = "gpio-backlight";
> +			gpios = <&pm8921_gpio 26 GPIO_ACTIVE_HIGH>;
> +			default-on;
> +		};
> +
> +		panel: auo,b101xtn01 {

panel: panel { ?

Regards,
Andreas

> +			status = "okay";
> +			compatible = "auo,b101xtn01";
> +
> +			ddc-i2c-bus = <&i2c3>;
> +			backlight = <&backlight>;
> +			power-supply = <&panel_3p3v>;
>  		};
>  
>  		gsbi3: gsbi@...00000 {
> @@ -235,6 +280,27 @@
>  				pm8921_gpio: gpio@150 {
>  					pinctrl-names = "default";
>  					pinctrl-0 = <&wlan_default_gpios>;
> +
> +					pwm_bl_gpios: pwm-bl-gpios {
> +						pios {
> +							pins = "gpio26";
> +							bias-disable;
> +							function = "normal";
> +							qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> +							power-source = <PM8921_GPIO_S4>;
> +						};
> +					};
> +
> +					disp_en_gpios: disp-en-gpios {
> +						pios {
> +							pins = "gpio36";
> +							bias-disable;
> +							function = "normal";
> +							qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>;
> +							power-source = <PM8921_GPIO_S4>;
> +						};
> +					};
> +
>  					wlan_default_gpios: wlan-gpios {
>  						pios {
>  							pins = "gpio43";
> 


-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/