linux-kernel - Re: [PATCH] staging: wilc1000: host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 29 Jul 2015 20:52:42 +0530
From:	Chandra Gorentla <csgorentla@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	johnny.kim@...el.com, rachel.kim@...el.com, dean.lee@...el.com,
	chris.park@...el.com, gregkh@...uxfoundation.org,
	linux-wireless@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: wilc1000: host_interface.c: Fix build warning

On Wed, Jul 29, 2015 at 05:20:37PM +0300, Dan Carpenter wrote:
> On Wed, Jul 29, 2015 at 07:36:59PM +0530, Chandra S Gorentla wrote:
> > Fixed - warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized 
> > 
> 
> I can't reproduce this warning and the original code looks fine to me.
> 
> When you say the word "fix" it means the code is buggy.  Otherwise we
> are just silencing warnings or cleaning up code.  It's not clear from
> the patch description what is happening here, is it a bug or a warning
> only?
> 
> regards,
> dan carpenter
> 
Following is the build log -
----
gcs@...-HP-Compaq-nx6320:~/linux/git-linux$ make ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- SUBFOLDER=drivers/staging/wilc1000/
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
make[1]: `include/generated/mach-types.h' is up to date.
  CHK     include/generated/bounds.h
  CHK     include/generated/timeconst.h
  CHK     include/generated/asm-offsets.h
  CALL    scripts/checksyscalls.sh
<stdin>:1298:2: warning: #warning syscall userfaultfd not implemented [-Wcpp]
  CHK     include/generated/compile.h
  CHK     kernel/config_data.h
  CC [M]  drivers/staging/wilc1000/host_interface.o
drivers/staging/wilc1000/host_interface.c: In function ‘host_int_add_beacon’:
drivers/staging/wilc1000/host_interface.c:7116:16: warning: ‘*((void *)&strHostIFmsg+4).pu8Head’ may be used uninitialized in this function [-Wuninitialized]
  LD [M]  drivers/staging/wilc1000/wilc1000.o
  Kernel: arch/arm/boot/Image is ready
  Kernel: arch/arm/boot/zImage is ready
  Building modules, stage 2.
  MODPOST 85 modules
  CC      drivers/staging/wilc1000/wilc1000.mod.o
  LDFINAL [M]  drivers/staging/wilc1000/wilc1000.ko
gcs@...-HP-Compaq-nx6320:~/linux/git-linux$
----
Proposed fix removes this warning.

Currently the 'wilc1000' driver in staging is marked as BROKEN in its
KConfig file at 'drivers/staging/wilc1000/'.  I had to remove this line
to execute the above make command.

Thanks,
chandra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/