linux-kernel - Re: [PATCH] asus-laptop: Add key found on Asus F3M

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150729044329.GA80946@vmdeb7>
Date:	Tue, 28 Jul 2015 21:43:29 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Łukasz Stelmach <stlman@...zta.fm>
Cc:	Corentin Chary <corentin.chary@...il.com>,
	acpi4asus-user@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] asus-laptop: Add key found on Asus F3M

Thanks Łukasz,

The following change seems reasonable.

While it's trivial, please provide some context in your commit message. I do not
merge commits with empty messages. There is always something to say. Did you see
a dmesg error, the key just didn't work, the 0x6A is new on model XYZ but you
don't know if others have it, it's from your personal experience, or came from
an ASUS manual, etc. There is always something to provide context which will be
useful to someone looking at this change - or looking for this fix when they hit
this problem on an older kernel.

Thanks,

On Fri, Jul 24, 2015 at 07:17:11PM +0200, Łukasz Stelmach wrote:
> Signed-off-by: Łukasz Stelmach <stlman@...zta.fm>
> ---
>  drivers/platform/x86/asus-laptop.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/asus-laptop.c b/drivers/platform/x86/asus-laptop.c
> index 58d29c4..f2b5d0a 100644
> --- a/drivers/platform/x86/asus-laptop.c
> +++ b/drivers/platform/x86/asus-laptop.c
> @@ -332,6 +332,7 @@ static const struct key_entry asus_keymap[] = {
>  	{KE_KEY, 0x65, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + TV */
>  	{KE_KEY, 0x66, { KEY_SWITCHVIDEOMODE } }, /* SDSP CRT + TV */
>  	{KE_KEY, 0x67, { KEY_SWITCHVIDEOMODE } }, /* SDSP LCD + CRT + TV */
> +	{KE_KEY, 0x6A, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad Fn + F9 */
>  	{KE_KEY, 0x6B, { KEY_TOUCHPAD_TOGGLE } }, /* Lock Touchpad */
>  	{KE_KEY, 0x6C, { KEY_SLEEP } }, /* Suspend */
>  	{KE_KEY, 0x6D, { KEY_SLEEP } }, /* Hibernate */
> -- 
> 2.1.4
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/