linux-kernel - Re: [PATCH] net/phy: micrel: Reenable interrupts during resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150729.235532.2011128033027594424.davem@davemloft.net>
Date:	Wed, 29 Jul 2015 23:55:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nathan.sullivan@...com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/phy: micrel: Reenable interrupts during resume

From: Nathan Sullivan <nathan.sullivan@...com>
Date: Wed, 29 Jul 2015 10:21:14 -0500

> diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> index 499185e..7a93af6 100644
> --- a/drivers/net/phy/micrel.c
> +++ b/drivers/net/phy/micrel.c
> @@ -447,6 +447,22 @@ static int ksz9031_center_flp_timing(struct phy_device *phydev)
>  	return genphy_restart_aneg(phydev);
>  }
>  
> +static int ksz9031_resume(struct phy_device *phydev)
> +{
> +	int result;
> +
> +	result = genphy_resume(phydev);
> +
> +	if (result)
> +		return result;
> +
> +	/* This phy will reset interrupt enables when leaving power down */
> +	if (PHY_INTERRUPT_ENABLED & phydev->interrupts)
> +		result = kszphy_set_interrupt(phydev);
> +

This doesn't compile.

drivers/net/phy/micrel.c: In function ‘ksz9031_resume’:
drivers/net/phy/micrel.c:461:3: error: implicit declaration of function ‘kszphy_set_interrupt’ [-Werror=implicit-function-declaration]
   result = kszphy_set_interrupt(phydev);
   ^
cc1: some warnings being treated as errors
scripts/Makefile.build:264: recipe for target 'drivers/net/phy/micrel.o' failed