linux-kernel - Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438239331.2144.18.camel@linaro.org>
Date:	Thu, 30 Jul 2015 09:55:31 +0300
From:	"Ivan T. Ivanov" <ivan.ivanov@...aro.org>
To:	Tim Bird <tbird20d@...il.com>
Cc:	Peter Chen <Peter.Chen@...escale.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v3] usb: chipidea: Use extcon framework for VBUS and ID
 detect


On Wed, 2015-07-29 at 12:10 -0700, Tim Bird wrote:
> On Tue, Jun 2, 2015 at 6:14 AM, Ivan T. Ivanov ivanov@...aro.org> wrote:
> > On recent Qualcomm platforms VBUS and ID lines are not routed to
> > USB PHY LINK controller. Use extcon framework to receive connect
> > and disconnect ID and VBUS notification.
> > 
> > Signed-off-by: Ivan T. Ivanov ivanov@...aro.org>
> > ---
> > Changes sice v2 [1].
> > 
> > * Simulate IRQ on extcon event - used to trigger OTG state machine.
> > 
> > I have to admit that I couldn't test complete Chipidea OTG state machine,
> > because my setup is little weird. I am using "qcom,usb-otg-ci" as PHY/OTG
> > provider, "qcom,ehci-host" as host controller driver and "qcom,ci-hdrc" for
> > device role.
> 
> Ivan,
> 
> Do you have patches for the code (presumably pmic code) where the vbus and id
> lines are signaled?  Presumably you've added some extcon_set_cable_state() calls
> somewhere in your source tree, for this to work.  I'm wondering if you
> can share your
> work in progress, or let me know when you plan to push that upstream?
> 

Well, not exactly. Maybe change description is badly worded. 
I have DB410c where VBUS and ID lines are not routed to USB controller, 
but to GPIO. So from the chipidea core driver point of view ID and VBUS
changes/IRQs are triggered from extcon driver "linux,extcon-usb-gpio"

> I'm interested in testing the msm usb code (specifically host mode support)
> on my dragonboard here.
> 

Since yesterday, Felipe kindly merged simple usb-phy driver for 8x16[1].
Which allow just using "qcom,ci-hdrc" and "qcom,usb-8x16-phy" to have
DRD support on 8x16 chipsets. I have tried to use "chipidea,usb2", but 
unfortunately quirks in "qcom,ci-hdrc" are required.

Once we have similar usb-phy drivers for 8x60, 8064, 8074 and 8084,
I believe the we can remove "qcom,usb-otg-xxx" monster. 

usb-phy driver for 8074 should be very similar to 8x16 one.

Regards,
Ivan

[1] http://bit.ly/1U6IjK4


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/