linux-kernel - [PATCHv1] mm: always initialize pages as reserved to fix memory hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1438265083-31208-1-git-send-email-david.vrabel@citrix.com>
Date:	Thu, 30 Jul 2015 15:04:43 +0100
From:	David Vrabel <david.vrabel@...rix.com>
To:	<linux-kernel@...r.kernel.org>
CC:	David Vrabel <david.vrabel@...rix.com>, <linux-mm@...ck.org>,
	Robin Holt <holt@....com>, Nathan Zimmer <nzimmer@....com>,
	Mel Gorman <mgorman@...e.de>
Subject: [PATCHv1] mm: always initialize pages as reserved to fix memory hotplug

Commit 92923ca3aacef63c92dc297a75ad0c6dfe4eab37 (mm: meminit: only set
page reserved in the memblock region) breaks memory hotplug because pages
within newly added sections are not marked as reserved as required by
the memory hotplug driver.  If pages within an offline section are not
reserved, the secton cannot be onlined.

Re-add the SetPageReserved() call.

Signed-off-by: David Vrabel <david.vrabel@...rix.com>
Cc: Robin Holt <holt@....com>
Cc: Nathan Zimmer <nzimmer@....com>
Cc: Mel Gorman <mgorman@...e.de>
---
 mm/page_alloc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ef19f22..89492f6 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -842,6 +842,7 @@ static void __meminit __init_single_page(struct page *page, unsigned long pfn,
 	init_page_count(page);
 	page_mapcount_reset(page);
 	page_cpupid_reset_last(page);
+	SetPageReserved(page);
 
 	INIT_LIST_HEAD(&page->lru);
 #ifdef WANT_PAGE_VIRTUAL
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/