linux-kernel - Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing *config* reg space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55BA47E0.9030003@ti.com>
Date:	Thu, 30 Jul 2015 11:50:56 -0400
From:	Murali Karicheri <m-karicheri2@...com>
To:	<jingoohan1@...il.com>, <pratyush.anand@...il.com>,
	<bhelgaas@...gle.com>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Resend: PATCH] PCI: designware: fix the boot noise for missing
 *config* reg space

On 07/21/2015 05:54 PM, Murali Karicheri wrote:
> Currently on Keystone SoCs, boot up log shows an unnecessary boot
> noise as follows:-
>
> [    0.365823] keystone-pcie 21021000.pcie: missing *config* reg space
>
> Keystone uses older version of designware h/w that doesn't have ATU
> support. So va_cfg0_base and va_cfg1_base are already set up in
> ks_dw_pcie_host_init() before calling dw_pcie_host_init() and
> they point to the remote config space address va (both same for Keystone).
> So add a check to avoid this boot noise on Keystone.
>
> Signed-off-by: Murali Karicheri <m-karicheri2@...com>
> ---
>   - Resend with "PCI: designware" prefix in subject
>   drivers/pci/host/pcie-designware.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
> index 69486be..b48b8a2 100644
> --- a/drivers/pci/host/pcie-designware.c
> +++ b/drivers/pci/host/pcie-designware.c
> @@ -388,7 +388,7 @@ int dw_pcie_host_init(struct pcie_port *pp)
>   		addrp = of_get_address(np, index, NULL, NULL);
>   		pp->cfg0_mod_base = of_read_number(addrp, ns);
>   		pp->cfg1_mod_base = pp->cfg0_mod_base + pp->cfg0_size;
> -	} else {
> +	} else if (!pp->va_cfg0_base) {
>   		dev_err(pp->dev, "missing *config* reg space\n");
>   	}
>
>
A gentle ping to review and apply this to pci next.

-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/